justinpark opened a new pull request, #29233: URL: https://github.com/apache/superset/pull/29233
### SUMMARY Following up #24539 This commit modifies the `removeQueryEditor` function to asynchronously handle the process of deleting a queryEditor in localStorage in the same way as in non-persistent mode and periodically post deleted items to persistence via AutoSync's `deleteSqlEditor`. This commit made the following changes: - In persistence mode, deleting a tab will no longer block the removal until it is fetched. Instead, the tab will be immediately discarded and stored the deleted ids in the local storage. (`destroyedQueryEditors`) - `removeQueryEditor` has been modified to always update to localStorage in the same way as in non-persistence mode - EditorAutoSync will execute `deleteSqlEditor` periodically and then remove the completed item from `destroyedQueryEditors` on success - Add the logic of storing localStorage `destroyedQueryEditors` for persistence mode ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: https://github.com/apache/superset/assets/1392866/a0c393dd-7d1c-474f-a7fb-8e88a61b3aea After: https://github.com/apache/superset/assets/1392866/0855d553-1c5f-4718-bdc0-372ca412a38c ### TESTING INSTRUCTIONS set SQLLAB_BACKEND_PERSISTENCE on go to sqllab and then close each tab quickly ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
