justinpark commented on code in PR #29233:
URL: https://github.com/apache/superset/pull/29233#discussion_r1640252015


##########
superset-frontend/src/SqlLab/components/EditorAutoSync/index.tsx:
##########
@@ -119,6 +126,22 @@ const EditorAutoSync: FC = () => {
     }
   });
 
+  const syncDeletedQueryEditor = useEffectEvent(() => {

Review Comment:
   This structure sends delete requests simultaneously, so if implemented with 
await, additional `Promise.all` handling might be required. Therefore, I intend 
to keep the current structure.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to