rtexelm opened a new pull request, #29234:
URL: https://github.com/apache/superset/pull/29234

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   This checks the presence of a query mode control in order to keep the 
relevant form data from being omitted as a result of controls being hidden 
between query modes
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   B:
   ![mode-switch-b-ezgif 
com-optimize](https://github.com/apache/superset/assets/92495987/3aa2b1fa-65fc-4a16-b65c-e468704d66e2)
   
![formdata-error](https://github.com/apache/superset/assets/92495987/4008069a-57f3-4e65-916d-8c88b79e394c)
   
   A:
   ![mode-switch-a-ezgif 
com-optimize](https://github.com/apache/superset/assets/92495987/166c169a-e6fa-4d8c-b319-b4df23548a0d)
   
![form-data-fixed](https://github.com/apache/superset/assets/92495987/9981d8c2-f72a-49a0-a859-e9d8c9acce7d)
   
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   - Pull up the `Games` chart or any table chart
   - Switch query modes
   - Table should render properly
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to