geido opened a new pull request, #30646: URL: https://github.com/apache/superset/pull/30646
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY This PR fixes an issue for which colors would sometimes not keep their consistency. This PR also attempts to fix and re-enable skipped E2E tests that are critical for the coverage of the color consistency implementation. ### BEFORE https://github.com/user-attachments/assets/d66e66ff-13ec-4bb1-a1bf-72f6afcd1bfc ### AFTER https://github.com/user-attachments/assets/fd74e76e-ea20-4d89-8f05-49455bcb5fd0 ### TESTING INSTRUCTIONS 1. Open a Dashboard with a color scheme and shared label colors 2. Edit the Dashboard properties and remove the color scheme 3. After applying the changes, verify that shared label colors are still respected 4. For charts that do not share labels, verify their original color scheme is respected 5. Save and exit the Dashboard by going to the Dashboard lists 6. Come back again to the same Dashboard you just saved 7. Make sure colors haven't changed from the previous state ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
