kgabryje commented on code in PR #30646:
URL: https://github.com/apache/superset/pull/30646#discussion_r1832737746
##########
superset-frontend/packages/superset-ui-core/src/color/CategoricalColorNamespace.ts:
##########
@@ -37,10 +37,23 @@ export default class CategoricalColorNamespace {
this.forcedItems = {};
}
- getScale(schemeId?: string) {
- const id = schemeId ?? getCategoricalSchemeRegistry().getDefaultKey() ??
'';
+ /**
+ * A new CategoricalColorScale instance is created for each chart.
Review Comment:
thanks for all those new docstrings!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
