EnxDev commented on code in PR #32112:
URL: https://github.com/apache/superset/pull/32112#discussion_r1983308015
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/actions.test.js:
##########
@@ -24,21 +24,44 @@ describe('Dashboard actions', () => {
cy.createSampleDashboards([0]);
cy.visit(SAMPLE_DASHBOARD_1);
});
-
it('should allow to favorite/unfavorite dashboard', () => {
interceptFav();
interceptUnfav();
+ // Find and click StarOutlined (adds to favorites)
cy.getBySel('dashboard-header-container')
- .find("[aria-label='favorite-unselected']")
+ .find("[aria-label='star']")
+ .as('starIconOutlined')
+ .should('exist')
.click();
+
cy.wait('@select');
+
+ // After clicking, StarFilled should appear
cy.getBySel('dashboard-header-container')
- .find("[aria-label='favorite-selected']")
- .click();
+ .find("[aria-label='star']")
Review Comment:
I think we should distinguish star filled from star outlined
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
