geido commented on code in PR #32112:
URL: https://github.com/apache/superset/pull/32112#discussion_r1984736576
##########
superset-frontend/cypress-base/cypress/applitools/dashboardlist.test.ts:
##########
@@ -28,18 +28,18 @@ describe('dashboard list view', () => {
});
it('should load the Dashboards list', () => {
- cy.get('[aria-label="list-view"]').click();
+ cy.get('[aria-label="unordered-list"]').click();
cy.eyesOpen({
- testName: 'Dashboards list-view',
+ testName: 'Dashboards UnorderedListOutlined',
Review Comment:
```suggestion
testName: 'Dashboards list-view',
```
##########
superset-frontend/cypress-base/cypress/applitools/dashboardlist.test.ts:
##########
@@ -28,18 +28,18 @@ describe('dashboard list view', () => {
});
it('should load the Dashboards list', () => {
- cy.get('[aria-label="list-view"]').click();
+ cy.get('[aria-label="unordered-list"]').click();
cy.eyesOpen({
- testName: 'Dashboards list-view',
+ testName: 'Dashboards UnorderedListOutlined',
});
- cy.eyesCheckWindow('Dashboards list-view loaded');
+ cy.eyesCheckWindow('Dashboards UnorderedListOutlined loaded');
});
it('should load the Dashboards card list', () => {
- cy.get('[aria-label="card-view"]').click();
+ cy.get('[aria-label="appstore"]').click();
cy.eyesOpen({
- testName: 'Dashboards card-view',
+ testName: 'Dashboards AppstoreOutlined',
Review Comment:
```suggestion
testName: 'Dashboards card-view',
```
##########
superset-frontend/cypress-base/cypress/applitools/dashboardlist.test.ts:
##########
@@ -28,18 +28,18 @@ describe('dashboard list view', () => {
});
it('should load the Dashboards list', () => {
- cy.get('[aria-label="list-view"]').click();
+ cy.get('[aria-label="unordered-list"]').click();
cy.eyesOpen({
- testName: 'Dashboards list-view',
+ testName: 'Dashboards UnorderedListOutlined',
});
- cy.eyesCheckWindow('Dashboards list-view loaded');
+ cy.eyesCheckWindow('Dashboards UnorderedListOutlined loaded');
Review Comment:
```suggestion
cy.eyesCheckWindow('Dashboards list-view loaded');
```
##########
superset-frontend/cypress-base/cypress/applitools/chartlist.test.ts:
##########
@@ -28,18 +28,18 @@ describe('charts list view', () => {
});
it('should load the Charts list', () => {
- cy.get('[aria-label="list-view"]').click();
+ cy.get('[aria-label="unordered-list"]').click();
cy.eyesOpen({
- testName: 'Charts list-view',
+ testName: 'Charts UnorderedListOutlined',
});
- cy.eyesCheckWindow('Charts list-view loaded');
+ cy.eyesCheckWindow('Charts UnorderedListOutlined loaded');
});
it('should load the Charts card list', () => {
- cy.get('[aria-label="card-view"]').click();
+ cy.get('[aria-label="appstore"]').click();
cy.eyesOpen({
- testName: 'Charts card-view',
+ testName: 'Charts AppstoreOutlined',
});
- cy.eyesCheckWindow('Charts card-view loaded');
+ cy.eyesCheckWindow('Charts AppstoreOutlined loaded');
Review Comment:
```suggestion
cy.eyesCheckWindow('Charts card-view loaded');
```
##########
superset-frontend/cypress-base/cypress/applitools/dashboardlist.test.ts:
##########
@@ -28,18 +28,18 @@ describe('dashboard list view', () => {
});
it('should load the Dashboards list', () => {
- cy.get('[aria-label="list-view"]').click();
+ cy.get('[aria-label="unordered-list"]').click();
cy.eyesOpen({
- testName: 'Dashboards list-view',
+ testName: 'Dashboards UnorderedListOutlined',
});
- cy.eyesCheckWindow('Dashboards list-view loaded');
+ cy.eyesCheckWindow('Dashboards UnorderedListOutlined loaded');
});
it('should load the Dashboards card list', () => {
- cy.get('[aria-label="card-view"]').click();
+ cy.get('[aria-label="appstore"]').click();
cy.eyesOpen({
- testName: 'Dashboards card-view',
+ testName: 'Dashboards AppstoreOutlined',
});
- cy.eyesCheckWindow('Dashboards card-view loaded');
+ cy.eyesCheckWindow('Dashboards AppstoreOutlined loaded');
Review Comment:
```suggestion
cy.eyesCheckWindow('Dashboards card-view loaded');
```
##########
superset-frontend/cypress-base/cypress/applitools/chartlist.test.ts:
##########
@@ -28,18 +28,18 @@ describe('charts list view', () => {
});
it('should load the Charts list', () => {
- cy.get('[aria-label="list-view"]').click();
+ cy.get('[aria-label="unordered-list"]').click();
cy.eyesOpen({
- testName: 'Charts list-view',
+ testName: 'Charts UnorderedListOutlined',
});
- cy.eyesCheckWindow('Charts list-view loaded');
+ cy.eyesCheckWindow('Charts UnorderedListOutlined loaded');
Review Comment:
```suggestion
cy.eyesCheckWindow('Charts list-view loaded');
```
##########
superset-frontend/cypress-base/cypress/applitools/chartlist.test.ts:
##########
@@ -28,18 +28,18 @@ describe('charts list view', () => {
});
it('should load the Charts list', () => {
- cy.get('[aria-label="list-view"]').click();
+ cy.get('[aria-label="unordered-list"]').click();
cy.eyesOpen({
- testName: 'Charts list-view',
+ testName: 'Charts UnorderedListOutlined',
});
- cy.eyesCheckWindow('Charts list-view loaded');
+ cy.eyesCheckWindow('Charts UnorderedListOutlined loaded');
});
it('should load the Charts card list', () => {
- cy.get('[aria-label="card-view"]').click();
+ cy.get('[aria-label="appstore"]').click();
cy.eyesOpen({
- testName: 'Charts card-view',
+ testName: 'Charts AppstoreOutlined',
Review Comment:
```suggestion
testName: 'Charts card-view',
```
##########
superset-frontend/cypress-base/cypress/applitools/chartlist.test.ts:
##########
@@ -28,18 +28,18 @@ describe('charts list view', () => {
});
it('should load the Charts list', () => {
- cy.get('[aria-label="list-view"]').click();
+ cy.get('[aria-label="unordered-list"]').click();
cy.eyesOpen({
- testName: 'Charts list-view',
+ testName: 'Charts UnorderedListOutlined',
Review Comment:
```suggestion
testName: 'Charts list-view',
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
