geido commented on code in PR #32514:
URL: https://github.com/apache/superset/pull/32514#discussion_r2028575765
##########
superset-frontend/cypress-base/cypress/e2e/chart_list/list.test.ts:
##########
@@ -84,9 +84,9 @@ describe('Charts list', () => {
it.only('should show the newly added dashboards in a tooltip', () => {
Review Comment:
Should this stay at `only` here? Not sure where this is coming from
##########
superset-frontend/src/components/Select/Select.tsx:
##########
@@ -635,10 +656,9 @@ const Select = forwardRef(
onSelect={handleOnSelect}
onClear={handleClear}
placeholder={placeholder}
- showSearch={shouldShowSearch}
- showArrow
tokenSeparators={tokenSeparators}
value={selectValue}
+ virtual={false}
Review Comment:
Should we be able to control this instead of forcing to false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
