msyavuz commented on code in PR #32514:
URL: https://github.com/apache/superset/pull/32514#discussion_r2028582438
##########
superset-frontend/src/components/Select/Select.tsx:
##########
@@ -635,10 +656,9 @@ const Select = forwardRef(
onSelect={handleOnSelect}
onClear={handleClear}
placeholder={placeholder}
- showSearch={shouldShowSearch}
- showArrow
tokenSeparators={tokenSeparators}
value={selectValue}
+ virtual={false}
Review Comment:
It is by default false. I added this just to make sure it was not antd
virtualization causing the crashes. I am not sure about letting usages control
`virtual` as our Select implementation is a bit complex and virtual might cause
some issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
