fardin-developer commented on code in PR #33013:
URL: https://github.com/apache/superset/pull/33013#discussion_r2034794833
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/controlPanel.ts:
##########
@@ -63,6 +67,28 @@ const config: ControlPanelConfig = {
config: { ...headerFontSize.config, default: 0.2 },
},
],
+ [
+ {
+ name: 'show_metric_name',
+ config: {
+ type: 'CheckboxControl',
+ label: t('Show Metric Name'),
+ renderTrigger: true,
+ default: true,
Review Comment:
> Should be weird if existing charts start showing the metric all of the
sudden, wouldn't be better to default to false?
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
