fardin-developer commented on code in PR #33013: URL: https://github.com/apache/superset/pull/33013#discussion_r2034831059
########## superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/utils.ts: ########## @@ -50,6 +64,10 @@ const comparisonFontSizesMapping = getFontSizeMapping( comparisonFontSizes, ); +export const getMetricNameFontSize = (proportionValue: number) => Review Comment: Thank you, I've DRYed it up, let me know if it looks good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
