Prokos opened a new issue, #33294: URL: https://github.com/apache/superset/issues/33294
### Bug description Using the `get_filters` jinja macro inside of a virtual dataset does not get a filter if the operator is set to IS NULL or IS NOT NULL. Because of this it also does not remove them when `remove_filter` is set to `true`. I haven't managed yet to get a dev version of Superset running, but I did find this line of code that might be the cause: https://github.com/apache/superset/blob/2a97a6ec1f61587aff861a8e7350ccc2d5c41b6b/superset/utils/core.py#L978 IS NULL and IS NOT NULL filters are the only SIMPLE filters that do not have a `comparator`. They fail this check, are not parsed properly from `form_data`, and therefore are ignored in the `get_filters` macro. ### Screenshots/recordings _No response_ ### Superset version 4.1.2 ### Python version I don't know ### Node version I don't know ### Browser Not applicable ### Additional context _No response_ ### Checklist - [x] I have searched Superset docs and Slack and didn't find a solution to my problem. - [x] I have searched the GitHub issue tracker and didn't find a similar bug report. - [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
