dosubot[bot] commented on issue #33294: URL: https://github.com/apache/superset/issues/33294#issuecomment-2841075708
<!-- Greeting --> Hello @Prokos! I'm [Dosu](https://dosu.dev), a bot here to help you with bugs, answer your questions, and assist you in becoming a contributor. I'm here while you wait for a human maintainer. Let's tackle this together! <!-- Answer --> The issue you're encountering with the `get_filters` Jinja macro in Apache Superset, where IS NULL and IS NOT NULL filters are ignored, is due to the fact that these filters are categorized as SIMPLE filters but do not have a `comparator`. This absence of a `comparator` leads to them being ignored during parsing from `form_data`, which prevents them from being retrieved or removed when `remove_filter` is set to true <sup>[[1]](https://github.com/apache/superset/blob/master/tests/integration_tests/datasource_tests.py)</sup>. To address this, you might need to modify the logic in the code to ensure that filters without a `comparator` are correctly processed. This could involve adjusting the parsing logic to recognize IS NULL and IS NOT NULL operators as valid even without a `comparator`. You can refer to the line of code you identified in `core.py` for potential adjustments <sup>[[1]](https://github.com/apache/superset/blob/master/tests/integration_tests/datasource_tests.py)</sup>. <!-- Dosu Comment Footer --> *To continue talking to [Dosu](https://dosu.dev), mention @dosu.* --- <sup>Help Dosu learn! Give it feedback: [Great Response](https://app.dosu.dev/response-feedback/c4bb09bb-daeb-4a43-a9d5-b497a8f10a45?feedback_type=great_response) | [Irrelevant Answer](https://app.dosu.dev/response-feedback/c4bb09bb-daeb-4a43-a9d5-b497a8f10a45?feedback_type=irrelevant_answer) | [Incorrect Sources](https://app.dosu.dev/response-feedback/c4bb09bb-daeb-4a43-a9d5-b497a8f10a45?feedback_type=incorrect_sources) | [Too Verbose](https://app.dosu.dev/response-feedback/c4bb09bb-daeb-4a43-a9d5-b497a8f10a45?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/c4bb09bb-daeb-4a43-a9d5-b497a8f10a45?feedback_type=hallucination) | [Bug Report](https://app.dosu.dev/response-feedback/c4bb09bb-daeb-4a43-a9d5-b497a8f10a45?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/c4bb09bb-daeb-4a43-a9d5-b497a8f10a45?feedback_type=other)</sup> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
