mistercrunch commented on PR #34235: URL: https://github.com/apache/superset/pull/34235#issuecomment-3098688919
in 2025 utf8 should be supported across the ecosystem really. So about the unit test you should be ok to cast to byte string on the right side of the assertion and pass the test (?) Just hoping that nothing is going to break here. Someone somewhere might use an old version of Excel and report an issue at some point. Unclear whether the whole ecosystem is ready for utf8 csv (?) Wondering if we need a checkbox "export as utf8" that people can check/uncheck. Though we could move to utf8 and wait issues to be reported to decide whether we should add a checkbox? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
