Habeeb556 commented on PR #34235:
URL: https://github.com/apache/superset/pull/34235#issuecomment-3099581129
I may have miscommunicated the intent in the PR summary—my concern isn’t
about outdated Excel versions, but rather the fact that the CSV file itself
isn’t interpreted correctly when it contains non-English characters (like
Arabic) even it's encoded with `utf-8-sig`. Since `Werkzeug 3` removed
automatic encoding, this needs to be just handled manually from the hard code.
By default, the encoding is set to `utf-8`, but it can be overridden by
specifying a custom value in `superset/config.py`
`CSV_EXPORT = {"encoding": "utf-8-sig"}` — this keeps the behavior
configurable based on deployment needs.
Tests are now updated to match the byte output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
