Antonio-RiveroMartnez commented on code in PR #34698:
URL: https://github.com/apache/superset/pull/34698#discussion_r2276785548
##########
superset-frontend/src/explore/components/ExploreViewContainer/index.jsx:
##########
@@ -541,7 +541,11 @@ function ExploreViewContainer(props) {
.map(message => {
const matchingLabels = controlsWithErrors
.filter(control => control.validationErrors?.includes(message))
- .map(control => control.label);
+ .map(control =>
+ typeof control.label === 'function'
Review Comment:
Not sure how feasible, but if a function, we should call the func before
setting the label that way the component doesn't need to be aware of this or
any other type and instead "just render", but not sure how worthy that approach
would be assuming it would require bigger changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
