kgabryje commented on code in PR #34698:
URL: https://github.com/apache/superset/pull/34698#discussion_r2276869559
##########
superset-frontend/src/explore/components/ExploreViewContainer/index.jsx:
##########
@@ -541,7 +541,11 @@ function ExploreViewContainer(props) {
.map(message => {
const matchingLabels = controlsWithErrors
.filter(control => control.validationErrors?.includes(message))
- .map(control => control.label);
+ .map(control =>
+ typeof control.label === 'function'
Review Comment:
That's true, it would be better to store the control values after
resolution, not before, but that requires some careful planning for the
refactor. The current flow makes it difficult to run the function fields
earlier (label is not the only one that can be either a function or a simple
value)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
