mistercrunch commented on PR #35215: URL: https://github.com/apache/superset/pull/35215#issuecomment-3314362225
Oh thanks for fixing this. Wondering if it would make more sense to add a loading state for the reusable modal instead. I think I shifted things so all properties modal use the same component, so maybe we could handle there instead of handling in the first section/form elements. Modal would need the context though as to whether it's loading, but should be doable no? Thinking further, wondering if we pop-fast with a spinner in-modal, or whether we spinner the trigger (trigger becomes a spinner, wait until it's loaded to pop the modal). Fine with either approach, spinner-in-modal is probably easier/best (?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
