rusackas commented on code in PR #35215:
URL: https://github.com/apache/superset/pull/35215#discussion_r2369563569
##########
superset-frontend/src/dashboard/components/PropertiesModal/sections/BasicInfoSection.tsx:
##########
@@ -31,54 +31,56 @@ const BasicInfoSection = ({
form,
isLoading,
validationStatus,
-}: BasicInfoSectionProps) => (
- <>
- <ModalFormField
- label={t('Name')}
- required
- testId="dashboard-name-field"
- error={
- validationStatus.basic?.hasErrors &&
- (!form.getFieldValue('title') ||
- form.getFieldValue('title').trim().length === 0)
- ? t('Dashboard name is required')
- : undefined
- }
- >
- <FormItem
- name="title"
- noStyle
- rules={[
- {
- required: true,
- message: t('Dashboard name is required'),
- whitespace: true,
- },
- ]}
+}: BasicInfoSectionProps) => {
+ const titleValue = form.getFieldValue('title');
+ const hasError =
+ !isLoading &&
+ validationStatus.basic?.hasErrors &&
+ (!titleValue || titleValue.trim().length === 0);
+
+ return (
+ <>
Review Comment:
Do we need this fragment? Looks like <ModalFormField> could be the wrapper
¯\\\_(ツ)_/¯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
