betodealmeida commented on code in PR #35420:
URL: https://github.com/apache/superset/pull/35420#discussion_r2395149424
##########
superset/sql/dialects/pinot.py:
##########
@@ -78,6 +78,12 @@ class Generator(MySQL.Generator):
exp.DataType.Type.UBIGINT: "UNSIGNED",
}
+ TRANSFORMS = {
+ **MySQL.Generator.TRANSFORMS,
+ }
+ # Remove DATE_TRUNC transformation - Pinot supports standard SQL
DATE_TRUNC
+ TRANSFORMS.pop(exp.DateTrunc, None)
Review Comment:
This is a common pattern in `sqlglot` dialects. "Practicality beats purity".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
