geido opened a new pull request, #35663: URL: https://github.com/apache/superset/pull/35663
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY Fixes inconsistent behaviors of the "local" label in Themes. ### BEFORE https://github.com/user-attachments/assets/ec8801a4-d50f-432a-9fe0-6ccf375f8d1c https://github.com/user-attachments/assets/adb9533b-bf0f-4d3b-8094-8eff01171953 https://github.com/user-attachments/assets/3eb59b9e-0d63-4d00-b1bc-15e45ddb129b ### AFTER https://github.com/user-attachments/assets/67e7bc98-7ae8-4e85-8844-ae6e687b02c5 https://github.com/user-attachments/assets/6e6289dc-a712-4d23-8b1c-58dab71a1d40 ### TESTING INSTRUCTIONS First issue: Local theme tag disappears after refresh - Navigate to themes - Select the thunder icon of a listed theme - it will be set as local theme and have a Local tag displayed - Refresh - The tag should not disappear Second issue: Unable to change theme to latest applied after setting a local theme - Navigate to themes - Click on Theme icon on top right - Select light - Select the thunder icon of a listed theme - it will be set as local theme and have a Local tag displayed - Click on thunder icon on top right - Select light again (the latest theme applied before local) - theme should be applied Third issue: Local theme tag keeps displayed after user removes it - Navigate to themes - Select the thunder icon of a listed theme - it will be set as local theme and have a Local tag displayed - Click Theme icon on top right - Select either dark or light - The theme is changed and local tag should not be displayed ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
