sadpandajoe commented on code in PR #35663:
URL: https://github.com/apache/superset/pull/35663#discussion_r2433541967
##########
superset-frontend/src/pages/ThemeList/index.tsx:
##########
@@ -119,6 +119,30 @@ function ThemesList({
const { showConfirm, ConfirmModal } = useConfirmModal();
+ const clearAppliedTheme = useCallback(() => {
+ setAppliedThemeId(null);
+ try {
+ localStorage.removeItem('superset-applied-theme-id');
+ } catch (error) {
+ // Ignore localStorage errors
+ }
+ }, []);
+
+ useEffect(() => {
+ if (hasDevOverride()) {
Review Comment:
what happens here if someone clears the override, does this hook get run
again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
