greggailly commented on code in PR #34111:
URL: https://github.com/apache/superset/pull/34111#discussion_r2447662079
##########
superset/sql_lab.py:
##########
@@ -475,7 +475,9 @@ def execute_sql_statements( # noqa: C901
db.session.commit()
# Hook to allow environment-specific mutation (usually comments)
to the SQL
- query.executed_sql = database.mutate_sql_based_on_config(block)
+ query.executed_sql = database.mutate_sql_based_on_config(
+ block, is_split=config["MUTATE_AFTER_SPLIT"]
Review Comment:
@giacomochiarella yes this is based on apache/superset:4.1.1. We have
MUTATE_AFTER_SPLIT = True as we need it for dashboards and charts.
Yes as long as the PR is not merged this change can break at any time when
upgrading. We will like into the new line when we will upgrade.
@mistercrunch do you think a temporary solution could be merged to keep a
consistent use of the DB_QUERY_MUTATOR for the moment ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
