msyavuz opened a new pull request, #35826:
URL: https://github.com/apache/superset/pull/35826

   ## Summary
   Fixes the "Match time shift color with original series" checkbox 
functionality in ECharts timeseries charts.
   
   The checkbox was not working because time-shifted series names (e.g., "28 
days ago") could not be properly mapped back to their original series for color 
matching.
   
   ## Changes
   - Added logic in `transformProps.ts` to detect time-shifted series by 
checking if series names match time comparison values
   - When a time-shifted series is detected, the code now finds the 
corresponding original series and uses its color key
   - This ensures time-shifted series use the same colors as their original 
series when the checkbox is enabled
   
   ## Test plan
   - [x] Create a line chart or any ECharts timeseries chart
   - [x] Add a time comparison (e.g., "28 days ago")
   - [x] Enable the "Match time shift color with original series" checkbox in 
Customize tab
   - [x] Verify that both original and time-shifted series now use the same 
colors
   - [x] Disable the checkbox and verify they use different colors again
   
   ## Before/After
   **Before**: Time-shifted series always used different colors regardless of 
checkbox state
   **After**: Time-shifted series match original series colors when checkbox is 
enabled
   
   🤖 Generated with [Claude Code](https://claude.ai/code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to