bito-code-review[bot] commented on PR #35826:
URL: https://github.com/apache/superset/pull/35826#issuecomment-3441732408
<details open>
<summary><strong>Interaction Diagram by <a
href="https://bito.ai#sequence_diagram";>Bito</a></strong></summary>
```mermaid
sequenceDiagram
participant Plugin as EchartsTimeseriesChartPlugin
participant TransformProps as transformProps.ts<br/>🔄 Updated | ●●○ Medium
participant SeriesLoop as Series Loop<br/>🔄 Updated | ●●○ Medium
participant GetOrig as getOriginalSeries
participant TransformSeries as transformSeries
participant EChart as ECharts Options
Plugin->>TransformProps: Call transformProps(chartProps)
TransformProps->>SeriesLoop: Iterate rawSeries entries
SeriesLoop->>GetOrig: Get initial colorScaleKey
GetOrig-->>SeriesLoop: Return base series name
Note over SeriesLoop: Check if series matches time-compare value
SeriesLoop->>SeriesLoop: Find original (non-time-compare) series
SeriesLoop->>GetOrig: Get colorScaleKey from original series
GetOrig-->>SeriesLoop: Return corrected series name
SeriesLoop->>TransformSeries: Pass corrected colorScaleKey
TransformSeries-->>SeriesLoop: Return styled series
SeriesLoop-->>EChart: Accumulate transformed series
TransformProps-->>Plugin: Return echartOptions with series
```
Critical path: EchartsTimeseriesChartPlugin->transformProps.ts->Series
Loop->getOriginalSeries->transformSeries->ECharts Options
> **Note:** The transformProps function now detects time-shifted series
(those matching time-compare values) and finds their original series to apply
correct color scaling. This ensures consistent coloring across time-comparison
visualizations by using the original series name for color key lookup instead
of the time-shifted variant.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
