korbit-ai[bot] commented on code in PR #35506:
URL: https://github.com/apache/superset/pull/35506#discussion_r2461985670
##########
superset-frontend/src/explore/components/controls/ComparisonRangeLabel.tsx:
##########
@@ -144,7 +144,8 @@ export const ComparisonRangeLabel = ({
);
const startDateDayjs = extendedDayjs(parseDttmToDate(startDate));
if (
- startDateDayjs.isSameOrBefore(parsedDateDayjs) ||
+ startDateDayjs.isBefore(parsedDateDayjs) ||
+ startDateDayjs.isSame(parsedDateDayjs) ||
Review Comment:
Understood. If TypeScript declarations are missing, maintaining separate
method calls might be necessary for type safety. In this case, the current
implementation may be the best approach given the constraints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
