korbit-ai[bot] commented on code in PR #35506:
URL: https://github.com/apache/superset/pull/35506#discussion_r2461990379
##########
superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-theme/Theme.stories.tsx:
##########
@@ -66,15 +59,17 @@ const AntDFunctionalColors = () => {
<strong>{type}</strong>
</td>
{variants.map(variant => {
- const color = themeObject.getColorVariants(type)[variant];
+ // Map to actual theme token names
+ const tokenName = `color${type.charAt(0).toUpperCase() +
type.slice(1)}${variant.charAt(0).toUpperCase() + variant.slice(1)}`;
+ const color = (supersetTheme as any)[tokenName];
return (
<td
key={variant}
style={{
border: '1px solid #ddd',
padding: '8px',
backgroundColor: color || 'transparent',
- color: `color${type}${variant}`,
+ color: color === 'transparent' ? 'black' : undefined,
Review Comment:
Thank you for the detailed explanation. Your points about the intentional
design, practical functionality, and risk assessment are well-taken. Given this
context, I agree that maintaining the current implementation is reasonable
unless specific issues arise in real-world usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
