villebro commented on code in PR #35259:
URL: https://github.com/apache/superset/pull/35259#discussion_r2505710616
##########
superset-core/src/superset_core/api/types/models.py:
##########
@@ -43,48 +45,48 @@ def get_session() -> scoped_session:
@staticmethod
@abstractmethod
- def get_dataset_model() -> Type[Any]:
+ def get_dataset_model() -> Type[Dataset]:
"""
- Retrieve the Dataset (SqlaTable) SQLAlchemy model.
+ Retrieve the Dataset (SqlaTable) implementation.
- :returns: The Dataset SQLAlchemy model class.
+ :returns: The Dataset implementation class.
"""
...
@staticmethod
@abstractmethod
- def get_database_model() -> Type[Any]:
+ def get_database_model() -> Type[Database]:
"""
- Retrieve the Database SQLAlchemy model.
+ Retrieve the Database implementation.
- :returns: The Database SQLAlchemy model class.
+ :returns: The Database implementation class.
"""
...
@staticmethod
@abstractmethod
- def get_datasets(query: BaseQuery | None = None, **kwargs: Any) ->
list[Any]:
+ def get_datasets(query: BaseQuery | None = None, **kwargs: Any) ->
list[Dataset]:
Review Comment:
Nice catch! Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
