villebro commented on code in PR #35259: URL: https://github.com/apache/superset/pull/35259#discussion_r2505738871
########## superset-core/src/superset_core/models/base.py: ########## @@ -0,0 +1,74 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Core model base classes.""" + +from typing import Any + +from flask_appbuilder import Model +from sqlalchemy.orm import Mapped + + +class CoreModel(Model): + """ + Abstract base class that extends Flask-AppBuilder's Model. + + This class provides the interface contract for all Superset models. + The host package provides concrete implementations. + """ + + __abstract__ = True + + +class Database(CoreModel): Review Comment: Yeah, I was actually originally leaning towards `BaseDatabase`, but I feel this may be the exception to the rule, as these will be used kind of like instances by extension developers (they get actual instances that implement the abstract class). But I'm not super opinionated on this. @michael-s-molina any thoughts here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
