eschutho commented on code in PR #35832:
URL: https://github.com/apache/superset/pull/35832#discussion_r2505970047
##########
superset/utils/slack.py:
##########
@@ -59,80 +56,162 @@ def get_slack_client() -> WebClient:
return client
-@cache_util.memoized_func(
- key="slack_conversations_list",
- cache=cache_manager.cache,
-)
-def get_channels() -> list[SlackChannelSchema]:
Review Comment:
Another note on this @gabotorresruiz, @Vitor-Avila added in caching on this
function and then another contributor added in a cache-warmup, so if we do
remove this, we should 1) carry over the caching but then 2) if we change the
name, let's double check that it won't be a breaking change for someone who has
cache-warmup turned on in their configs. Also @Vitor-Avila how does this
caching work with the cursor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
