gabotorresruiz commented on code in PR #35832:
URL: https://github.com/apache/superset/pull/35832#discussion_r2543882245
##########
superset/reports/api.py:
##########
@@ -577,14 +577,17 @@ def slack_channels(self, **kwargs: Any) -> Response:
search_string = params.get("search_string")
types = params.get("types", [])
exact_match = params.get("exact_match", False)
- force = params.get("force", False)
- channels = get_channels_with_search(
+ cursor = params.get("cursor")
+ limit = params.get("limit", 100)
Review Comment:
Good questions! Let me address each:
**1. Do we need cursor and limit?**
Yes, both are needed:
- **cursor**: Required for pagination. Frontend passes cursor to get next
page. Also needed for the `api:continue` approach you mentioned.
- **limit**: Controls page size for the dropdown component.
**2. Should limit default to 999 instead of 100?**
Yes we should!
**3. Should we preserve force for cache refresh?**
Yes we should!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
