shivamsahu-tech opened a new pull request, #36059:
URL: https://github.com/apache/superset/pull/36059

   fix(UI): remove getPopupContainer prop causing dual scrollbars in dropdown 
menus (#35833)
   
   ### SUMMARY
   This PR fixes the **dual scrollbar issue** appearing in dropdown menus.
   
   The issue occurred because the `getPopupContainer` prop was being passed to 
the **Ant Design Select** component in both:
   - 
`superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx`
   - `superset-frontend/src/features/databases/DatabaseModal/index.tsx`
   
   This prop forced dropdowns to render inside their **parent container** 
rather than the default `document.body`.  
   Since these parent containers have constrained height and overflow 
properties, the dropdown scrolled within the parent component, resulting in 
**dual scrollbars** and **clipped dropdowns**.
   
   ### BEFORE/AFTER SCREENSHOTS
   
   #### Before (with issue)
   ![Before 
Chrome](https://drive.google.com/uc?export=view&id=1SJ8Php4oRh3_cEJTL1xGa3IGxzMUJPON)
   
   #### After (fixed)
   ![After 
Chrome](https://drive.google.com/uc?export=view&id=18U5_HJ0slhJ839KwOpL19YwuLYBPAovd)
   
   ### TESTING INSTRUCTIONS
   1. Go to **Settings → Database Connections** in Superset.  
   2. Click **Databases**, and open any supported database dropdown.  
   3. Observe that the dropdown no longer shows dual scrollbars.  
   4. Verify that dropdowns render fully and correctly without layout clipping. 
 
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: Fixes #35833  
   - [ ] Required feature flags: None  
   - [x] Changes UI (fixes visual bug)  
   - [ ] Includes DB Migration  
   - [ ] Introduces new feature or API  
   - [ ] Removes existing feature or API  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to