sadpandajoe commented on code in PR #36050:
URL: https://github.com/apache/superset/pull/36050#discussion_r2547921100
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx:
##########
@@ -470,6 +681,18 @@ export class TableRenderer extends Component {
namesMapping,
allowRenderHtml,
)}
+ <span
+ role="columnheader"
+ tabIndex={0}
+ // Prevents event bubbling to avoid conflict with column header
click handlers
+ // Ensures sort operation executes without triggering
cross-filtration
+ onClick={e => {
+ e.stopPropagation();
+ }}
+ aria-label={`Sorted by ${columnName}`}
Review Comment:
does the `aria-label` still say sorted even if it isn't sorted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
