sadpandajoe commented on code in PR #36050:
URL: https://github.com/apache/superset/pull/36050#discussion_r2547930844
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx:
##########
@@ -878,8 +1101,13 @@ export class TableRenderer extends Component {
return document.contains(document.querySelector('.dashboard--editing'));
}
+ componentWillUnmount() {
+ this.sortCache.clear();
+ }
+
render() {
if (this.cachedProps !== this.props) {
+ this.sortCache.clear();
Review Comment:
On prop changes we clear the sort cache and rebuild base settings but do we
still leave activeSortColumn/sortingOrder intact? If so the header will still
shows a sort while rowKeys revert to the base order, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
