villebro commented on a change in pull request #7643: 7620: Start removing
dependencies on requests
URL:
https://github.com/apache/incubator-superset/pull/7643#discussion_r298258278
##########
File path: superset/connectors/druid/models.py
##########
@@ -31,20 +31,26 @@
from flask_appbuilder.models.decorators import renders
from flask_babel import lazy_gettext as _
import pandas
-from pydruid.client import PyDruid
-from pydruid.utils.aggregators import count
-from pydruid.utils.dimensions import MapLookupExtraction, RegexExtraction
-from pydruid.utils.filters import Dimension, Filter
-from pydruid.utils.having import Aggregation
-from pydruid.utils.postaggregator import (
- Const,
- Field,
- HyperUniqueCardinality,
- Postaggregator,
- Quantile,
- Quantiles,
-)
-import requests
+try:
+ from pydruid.client import PyDruid
+ from pydruid.utils.aggregators import count
+ from pydruid.utils.dimensions import MapLookupExtraction, RegexExtraction
+ from pydruid.utils.filters import Dimension, Filter
+ from pydruid.utils.having import Aggregation
+ from pydruid.utils.postaggregator import (
+ Const,
+ Field,
+ HyperUniqueCardinality,
+ Postaggregator,
+ Quantile,
+ Quantiles,
+ )
+ import requests
+except ImportError:
+ print(_('pydruid and requests are optional dependencies, and '
+ 'it seems they are not installed on your system. Some features '
+ 'might not be available.'))
Review comment:
On second thought I would probably just `pass` here; since `pydruid` is
optional (along with `requests`), I don't think it's necessary to state that
they are missing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
