villebro commented on a change in pull request #7643: 7620: Start removing
dependencies on requests
URL:
https://github.com/apache/incubator-superset/pull/7643#discussion_r298258842
##########
File path: superset/connectors/druid/models.py
##########
@@ -65,10 +71,15 @@
from superset.exceptions import MetricPermException, SupersetException
from superset.models.helpers import AuditMixinNullable, ImportMixin,
QueryResult
from superset.utils import core as utils, import_datasource
-from superset.utils.core import DimSelector, DTTM_ALIAS, flasher
-
-DRUID_TZ = conf.get("DRUID_TZ")
-POST_AGG_TYPE = "postagg"
+try:
+ from superset.utils.core import (
+ DimSelector, DTTM_ALIAS, flasher,
+ )
+except ImportError:
+ print(_('DimSelector depends on Having, but it is not available '
+ 'because pydruid is an optional dependency'))
Review comment:
Same here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
