manojshetty2004 commented on PR #36229: URL: https://github.com/apache/superset/pull/36229#issuecomment-3585170291
Thanks for the thoughtful feedback! To clarify the use case: this issue occurs specifically when embedding Superset **without the official SDK iframe**, i.e. when the host app injects the dashboard markup directly into its DOM (for example: Angular/React apps using a proxied Superset session and mounting the dashboard into a div). In this scenario, the host application's global CSS (e.g., resets from Material, Tailwind, Bootstrap, or global layout rules) can override Superset’s native grid layout. This leads to the “zero-gap / collapsed spacing” issue shown in the screenshot. So these styles are not meant to *alter* Superset’s appearance, but to *restore* the expected default spacing when Superset is DOM-embedded without isolation. I completely agree that: - iframe-based SDK embedding avoids this problem, and - the new Theming system is the future for intentional style overrides. This PR only restores the default layout in the non-SDK embedding case, and is fully scoped under `.superset-embed` so it won't affect standard Superset usage or SDK iframe embeds. Happy to adjust or refine the implementation if needed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
