manojshetty2004 commented on PR #36229: URL: https://github.com/apache/superset/pull/36229#issuecomment-3605087490
Thanks for the clarification — totally understand that iframe-based embedding is the preferred/official method. Just to clarify the real-world scenario here: a number of teams embed Superset dashboards *without* the Embedded SDK iframe, by mounting Superset directly into an existing app’s DOM (usually because the host app already handles auth, routing, layout, and needs tighter integration for internal tooling). In these setups, global CSS from the host framework (Angular Material, Tailwind, Bootstrap, PrimeNG, etc.) can override Superset’s grid spacing and box-model rules. This causes the collapsed “no gap” dashboard layout shown in the screenshot. This isn’t specific to our project — it happens for anyone embedding Superset this way. The change in this PR does not alter Superset’s look or theming; it simply restores Superset’s expected default spacing when its layout is unintentionally overridden. The styles are fully scoped under `.superset-embed`, so they have zero effect on normal Superset usage or the official Embedded SDK. If you prefer a different selector, placement, or theme token for this, I’m happy to adjust. My goal is just to prevent unintended layout breakage in legitimate (though unofficial) embed scenarios. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
