JoshuaJADaniel commented on PR #36201: URL: https://github.com/apache/superset/pull/36201#issuecomment-3590379307
@rusackas > Should parts of this work without the Javascript Controls feature flag turned on? I.e. Should I still be able to pick an icon URL, adjust size, or maybe use some of the other inputs (color, etc.)? If some of these new features work without Javascript inptus, that would be nice to leave those features enabled. I was under the impression that the JS inputs just add _even more_ flexibility, and were somewhat optional. Correct me if I'm misunderstanding :) You are correct on everything you said here -- the JS inputs just adds more flexibility. This behavior is still maintained after 740b3c2f68daaa2004ff7f08189b108d5f754f5c; it might be confusing because I was accounting for a potential edge case if I only changed the JS fields visibility logic. Scenario: *a user initially had the JS feature flag turned on, then enabled JS mode on the visualization, then turned the JS feature flag off*. If this happens, then all the customization controls would be hidden (the non-JS fields would be hidden because JS mode is enabled and the JS fields would be hidden because the feature flag is turned off). To avoid this, I show the non-JS fields if JS mode is disabled OR the feature flag is turned off. For example, here is the label color control: <img width="613" height="338" alt="image" src="https://github.com/user-attachments/assets/d262d049-4798-47bd-9a3e-68595bfb4888"; /> Hopefully it makes sense (I can clarify further if needed). In any case, if it is not an edge case we need to consider, I can only change the JS fields visibility logic (which is what I believe you were expecting initially). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
