rusackas commented on PR #36201: URL: https://github.com/apache/superset/pull/36201#issuecomment-3628770987
OK, finally testing this now, and running into some questions/feedback: * It looks like this (pre-existing) control for labels/markdown isn't working right. Not sure if it does outside of this PR: <img width="282" height="308" alt="image" src="https://github.com/user-attachments/assets/0c6275fe-c43c-4143-8c1a-990641165408"; /> But it _seems_ like it kind of covers both use cases of this PR? I'm not sure where that feature falls short. * It looks like you can use Labels OR Icons, but not both, is that accurate? I'm wondering if a "Labels/Icons/None" Select would make more sense, and showing/hiding the relevant controls according to the option selected. * If you choose settings for the image, and uncheck/re-check the "Image" box, the settings are wiped/lost. Would be nice to persist that. * The icon size options seem sensible, but i wonder if we should allow a freeform entry there. * If you have an icon selected/working, then check the "Text" option, it hides the icons and shows the text (awesome!) but does not show the icon again if you un-check "Text" * Changing the settings for icons doesn't seem to refresh the viz, even though the controls seem to indicate that they should. You have to click Update... so something probably just isn't getting sent to TransformProps quite right or something like that. I'm most curious about the first point, regarding the markdown controls, and if/how we should get those working, and whether or not that would solve the same purposes of rendering different properties, adding icons, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
