rusackas commented on PR #36345: URL: https://github.com/apache/superset/pull/36345#issuecomment-3598387927
It looks like there's a fair bit of custom logic going on here... we'll read through and see if any of it seems like it could be simplified. Would it be possible to add some tests? This is definitely a core experience we don't want regressing. I'll spin up an ephemeral environment so we can all test. Last but not least, does this allow us to delete a bunch of the existing UI code/components in favor of this approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
