FelipeGLopez opened a new pull request, #36422:
URL: https://github.com/apache/superset/pull/36422

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Fixes SQL validation endpoint to properly handle Jinja templates before 
validation. Previously, the `/api/v1/database/<id>/validate_sql/` endpoint 
would fail with syntax errors when SQL contained Jinja template syntax (e.g., 
`{% if %}`, `{{ variable }}`), as it was passing raw templates directly to the 
database validator.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   SQL validation fails with `ERROR: syntax error at or near "{"` when Jinja 
templates are present in the query.
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   Jinja templates are rendered with provided parameters (or defaults) before 
validation, allowing SQL Lab to correctly validate templated queries.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [X] Required feature flags: `ENABLE_TEMPLATE_PROCESSING`
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to