greggailly commented on code in PR #36071:
URL: https://github.com/apache/superset/pull/36071#discussion_r2595020583
##########
superset-frontend/src/dashboard/components/PropertiesModal/PropertiesModal.test.tsx:
##########
@@ -209,7 +209,7 @@ describe('PropertiesModal', () => {
expect(screen.getByRole('button', { name: 'Save' })).toBeInTheDocument();
// Only General information section is expanded by default
- expect(screen.getAllByRole('textbox')).toHaveLength(2); // Name and Slug
+ expect(screen.getAllByRole('textbox')).toHaveLength(3); // Name, Slug and
Description
Review Comment:
Could be done (not tested) but it this case I would not do it (in my
opinion) in the same PR just for clarity.
##########
superset-frontend/src/dashboard/components/PropertiesModal/PropertiesModal.test.tsx:
##########
@@ -299,7 +299,7 @@ describe('PropertiesModal', () => {
await screen.findByTestId('dashboard-edit-properties-form'),
).toBeInTheDocument();
- expect(screen.getAllByRole('textbox')).toHaveLength(2); // Only Name and
Slug visible initially
+ expect(screen.getAllByRole('textbox')).toHaveLength(3); // Only Name, Slug
and Description visible initially
Review Comment:
Could be done (not tested) but it this case I would not do it (in my
opinion) in the same PR just for clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
