rusackas commented on code in PR #36071:
URL: https://github.com/apache/superset/pull/36071#discussion_r2599489747
##########
superset-frontend/src/dashboard/components/PropertiesModal/index.tsx:
##########
@@ -280,7 +282,7 @@ const PropertiesModal = ({
};
const onFinish = () => {
- const { title, slug, certifiedBy, certificationDetails } =
+ const { title, description, slug, certifiedBy, certificationDetails } =
Review Comment:
Well, we're more or less OK since downstream it gets cleaned up via
`description || null` but this would be the upstream place to set it as an
empty string for downstream consumption or any other future consumers of it.
So... not _necessary_ but it does seem like a decent/safe idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
