innovark37 opened a new pull request, #36536: URL: https://github.com/apache/superset/pull/36536
### SUMMARY This PR fixes a layout issue in modal dialogs where long titles overlap with the close (X) button. This issue became more noticeable with custom theming when the `titleFontSize` token for the Modal component was set to a larger value. #### Changes: 1. **Fixed title padding:** Updated the ant-modal-title CSS to use the close button's width as right padding. 2. **Ensured proper text flow:** Title text now correctly wraps to a new line before reaching the close button area. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF BEFORE <img width="626" height="318" alt="Screenshot 2025-12-11 192326" src="https://github.com/user-attachments/assets/dd37c07a-cacd-45ee-aa54-254af423af8c"; /> AFTER <img width="631" height="320" alt="Screenshot 2025-12-11 191312" src="https://github.com/user-attachments/assets/6641d9d4-f91e-47e4-8738-299f3f0d7ab7"; /> ### TESTING INSTRUCTIONS 1. Navigate to any page where you can trigger a modal (e.g., editing/deleting a Dashboard, Chart, etc). 2. Open any modal dialog 3. Open DevTools Elements Panel 4. Locate the modal title element 5. Edit the title text to a very long version 6. Observe the result: - the title should automatically wrap to a new line; - clear spacing should appear between the text and the close (✕) button; - no visual overlap — the button should remain completely unobstructed. ``` ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
