codeant-ai-for-open-source[bot] commented on PR #36536: URL: https://github.com/apache/superset/pull/36536#issuecomment-3642770018
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36536/files#diff-d0b8d07b9ed3b88776a24fc28afc88f624e5676332d7b60855ca28f2a3f59adfR154-R165'><strong>Draggable layout regression</strong></a><br>The new right-padding that prevents title overlap is applied to `.ant-modal-header` but the draggable variant resets header padding to 0 and uses `.draggable-trigger` padding. The draggable header doesn't account for the close button width, which can reintroduce overlap when `draggable === true`.<br> - [ ] <a href='https://github.com/apache/superset/pull/36536/files#diff-d0b8d07b9ed3b88776a24fc28afc88f624e5676332d7b60855ca28f2a3f59adfR87-R95'><strong>Title wrapping risk</strong></a><br>`.ant-modal-title h4` is a flex container. Long title text may still overflow or refuse to wrap inside flex layout unless the flex item is allowed to shrink (e.g. `min-width: 0` or `flex: 1 1 auto`) and explicit wrapping rules are added.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
