ankitajhanwar2001 opened a new pull request, #36747: URL: https://github.com/apache/superset/pull/36747
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR updates the SQLGlot dialect mapping for AWS Athena from `PRESTO` to `ATHENA`. Athena-specific SQL syntax (e.g., `USING EXTERNAL FUNCTION`) now parses correctly in Superset, preventing “Unable to parse SQL” errors for queries that are valid in Athena but not in Presto. ### Related Issue Fixes #36717 ### Changes - Updated SQLGlot dialect mapping for `awsathena` in `superset/sql/parse.py` - Added unit tests in `tests/unit_tests/sql/parse_tests.py` covering Athena-specific SQL parsing - Verified parsing does not fail for `USING EXTERNAL FUNCTION` constructs - Tested with local Superset Athena database connection ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> N/A ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. **Unit tests** ```bash pytest tests/unit_tests/sql/parse_tests.py 2. **Local Superset setup with Athena** - Configure Athena database connection locally in Superset. - Execute a query using USING EXTERNAL FUNCTION, e.g.: ```bash USING EXTERNAL FUNCTION decrypt(data varbinary) RETURNS VARCHAR LAMBDA 'arn:aws:lambda:ap-south-1:123456789111:function:lambda-test' SELECT 1 - Verify parsing succeeds and no Superset errors occur. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: #36717 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
