ankitajhanwar2001 commented on code in PR #36747:
URL: https://github.com/apache/superset/pull/36747#discussion_r2635856074
##########
superset/sql/parse.py:
##########
@@ -58,7 +58,7 @@
SQLGLOT_DIALECTS = {
"base": Dialects.DIALECT,
"ascend": Dialects.HIVE,
- "awsathena": Dialects.PRESTO,
+ "awsathena": Dialects.ATHENA,
Review Comment:
While older Superset versions used sqlglot releases without ATHENA, current
supported versions pin sqlglot with this dialect available. A fallback to
PRESTO would hide incompatibilities and reintroduce incorrect parsing behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
