rusackas commented on code in PR #36760:
URL: https://github.com/apache/superset/pull/36760#discussion_r2642206987
##########
superset-frontend/src/explore/components/controls/SelectControl.tsx:
##########
@@ -316,11 +370,9 @@ export default class SelectControl extends PureComponent {
}
`}
>
- <Select {...selectProps} />
+ {/* eslint-disable-next-line @typescript-eslint/no-explicit-any */}
+ <Select {...(selectProps as any)} />
Review Comment:
The `any` cast and eslint-disable are documenting existing type complexity
in this component. The `SelectControl` handles multiple input types (strings,
numbers, objects) which makes precise typing complex. This is marked for future
type improvement as part of the broader controls typing effort.
##########
superset-frontend/src/explore/controlUtils/standardizedFormData.ts:
##########
@@ -211,13 +211,15 @@ export class StandardizedFormData {
publicFormData[key] = exploreState.form_data[key];
}
});
- const targetControlsState = getControlsState(exploreState, {
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
+ const targetControlsState = getControlsState(exploreState as any, {
Review Comment:
These casts are necessary because `getControlsState()` returns
`Record<string, unknown>` but the code expects more specific types. The
function's return type would need to be updated across multiple files to
properly type this. Documented as technical debt for future cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
