bito-code-review[bot] commented on code in PR #36760:
URL: https://github.com/apache/superset/pull/36760#discussion_r2642207986
##########
superset-frontend/src/explore/components/controls/MetricControl/MetricsControl.tsx:
##########
@@ -57,13 +57,14 @@ const defaultProps = {
columns: [],
};
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
function getOptionsForSavedMetrics(
- savedMetrics,
- currentMetricValues,
- currentMetric,
+ savedMetrics: any,
+ currentMetricValues: any,
+ currentMetric: any,
) {
Review Comment:
<!-- Bito Reply -->
Yes, using `any` types with `eslint-disable` comments is a valid approach
for documenting technical debt during a large JS→TS migration. It allows the
conversion to proceed without requiring extensive refactoring of complex
Redux/form state interactions, which can be addressed in follow-up work.
**superset-frontend/src/explore/components/controls/MetricControl/MetricsControl.tsx**
```
// eslint-disable-next-line @typescript-eslint/no-explicit-any
function getOptionsForSavedMetrics(
savedMetrics: any,
currentMetricValues: any,
currentMetric: any,
) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
